-
Notifications
You must be signed in to change notification settings - Fork 22.7k
Lint: fix CSS syntax and some antipatterns #39685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one page needs fixin'.
Thanks!
@@ -169,7 +169,7 @@ The `.boxLeft` class, used to style the box on the left, sets up the color of th | |||
background-color: hwb(270deg 63% 13%); | |||
outline: 4px dashed #6e1478; | |||
color: hsl(0deg 100% 100%); | |||
text-decoration: underline; | |||
text-decoration-line: underline; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we have 3 long hands then the shorthand. Safari doesn't understand thickness in the shorthand, but this value doesn't include that property, so we can just use the shorthand and get ride of the note after this block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also remove "along with the longhand component for browser compatibility" before
'We used the 3-digit {{cssxref("hex-color")}} #8f8
, which is the equivalent of #88ff88
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle Unfortunately the latest Safari still does not support this. Note that in the text-decoration
BCD table, "text-decoration-color and text-decoration-style included in shorthand" for Safari says "Implemented with the vendor prefix: -webkit-". I've tried on Safari 18.5.
clip
never supportedrect
without commas; remove that syntax@media
not
description because it's incorrect